Tensor arithmetic #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f Parameters. Also fix some exception messages.
… of variables instead of VariableIdentityMap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to add and multiply vectors and matrices. This includes extended support for function types, including variadic functions.
This PR only includes full support for the
BasicEvaluator. TheCompilingEvaluatorcan add but not yet multiply vectors and matrices. That will be the subject of a future PR.There are still a number of edge cases that produce false positives (for example, multiplying two vectors is not clearly defined, but no error is produced in the repl). Those will have to be worked out.